Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40064: Add configuration to override default psfex reference flux. #72

Merged
merged 2 commits into from Sep 20, 2023
Merged

DM-40064: Add configuration to override default psfex reference flux. #72

merged 2 commits into from Sep 20, 2023

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Sep 18, 2023

No description provided.

parejkoj
parejkoj reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments about naming and defaults.

I was going to suggest removing the PHOTFLUX_KEY lines from the default-lsst.psfex file, but I guess the other fields we override are still in there.

python/lsst/meas/extensions/psfex/psfexPsfDeterminer.py Show resolved Hide resolved
tests/test_PsfexPsf.py Outdated Show resolved Hide resolved
python/lsst/meas/extensions/psfex/psfexPsfDeterminer.py Outdated Show resolved Hide resolved
python/lsst/meas/extensions/psfex/psfexPsfDeterminer.py Outdated Show resolved Hide resolved
@erykoff erykoff merged commit beb006f into main Sep 20, 2023
2 checks passed
@erykoff erykoff deleted the tickets/DM-40064 branch September 20, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erykoff @parejkoj