Merge pull request #478 from lsst/tickets/DM-42837

Fix radial distortion documentation.

.pre-commit-config.yaml

@@ -7,7 +7,7 @@ repos:
       - id: trailing-whitespace
       - id: check-toml
   - repo: https://github.com/psf/black
-    rev: 23.11.0
+    rev: 24.1.1
     hooks:
       - id: black
         # It is recommended to specify the latest version of Python
@@ -16,12 +16,12 @@ repos:
         # https://pre-commit.com/#top_level-default_language_version
         language_version: python3.11
   - repo: https://github.com/pycqa/isort
-    rev: 5.12.0
+    rev: 5.13.2
     hooks:
       - id: isort
         name: isort (python)
   - repo: https://github.com/astral-sh/ruff-pre-commit
     # Ruff version.
-    rev: v0.1.6
+    rev: v0.1.15
     hooks:
       - id: ruff

python/lsst/obs/base/_read_curated_calibs.py

@@ -42,11 +42,9 @@ class CuratedCalibration(Protocol):
     """
 
     @classmethod
-    def readText(cls, path: str) -> CuratedCalibration:
-        ...
+    def readText(cls, path: str) -> CuratedCalibration: ...
 
-    def getMetadata(self) -> Mapping:
-        ...
+    def getMetadata(self) -> Mapping: ...
 
 
 def read_one_calib(

python/lsst/obs/base/yamlCamera.py

@@ -246,8 +246,8 @@ def makeTransformDict(nativeSys, transformDict, plateScale):
 
             transform = afwGeom.makeTransform(affine)
         elif transformType == "radial":
-            # radial coefficients of the form [0, 1 (no units), C2 (rad),
-            # usually 0, C3 (rad^2), ...]
+            # radial coefficients of the form
+            #   [0, 1 (no units), C2 (mm^-1), usually 0, C4 (mm^-3), ...]
             # Radial distortion is modeled as a radial polynomial that converts
             # from focal plane radius (in mm) to field angle (in radians).
             # The provided coefficients are divided by the plate

setup.cfg

@@ -1,7 +1,7 @@
 [flake8]
 max-line-length = 110
 max-doc-length = 79
-ignore = E133, E226, E228, N802, N803, N806, N812, N815, N816, W503, E203
+ignore = E133, E226, E228, E704, N802, N803, N806, N812, N815, N816, W503, E203
 exclude = __init__.py, tests/camera/camera.py
 
 [tool:pytest]