Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix radial distortion documentation. #478

Merged
merged 4 commits into from Feb 20, 2024
Merged

Fix radial distortion documentation. #478

merged 4 commits into from Feb 20, 2024

Conversation

jmeyers314
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@cmsaunders
Copy link
Contributor

Looks good. I agree with your logic on what the dimensions should be. I'm not sure what the policy is on black errors on code you haven't touched.

@timj
Copy link
Member

timj commented Feb 19, 2024

To fix black you can cherry pick my commits from #477.

Currently they are:

  • 4adbc1c - Add new ignore required by black (3 weeks ago)
  • 67dbed0 - Fixes for black v24.1 (3 weeks ago)
  • 7f88795 - Refresh pre-commit (3 weeks ago)

@jmeyers314 jmeyers314 merged commit f1174df into main Feb 20, 2024
6 checks passed
@jmeyers314 jmeyers314 deleted the tickets/DM-42837 branch February 20, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jmeyers314 @cmsaunders @timj