Change creation pattern and support distortion in YamlCamera #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a makeCamera function rather than inheriting from Camera. The support for distortion models is mostly in makeTransformDict, and required clarification that all models are *from* native *to* other which is a change from at least some other cameras. N.b. makeCamera required that we changed a number of methods to be functions, which accounts for most of the changes.
timj
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
More comments than you'd like because I ended up reading all the code. There are a couple of substantive issues: that loop early on, Loader vs CLoader, and legacy afwGeom.angle usage that should be geom. It would be nice if the other issues were fixed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a makeCamera function rather than inheriting from Camera.
The support for distortion models is mostly in makeTransformDict,
and required clarification that all models are
from native to other
which is a change from at least some other cameras.
N.b. makeCamera required that we changed a number of methods to be
functions, which accounts for most of the changes.