DM-21849: Adapt gen2to3 to use chained collections. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-21849
branch
4 times, most recently
from
0a17eb9
to
0d043a7
Compare
TallJimbo
force-pushed
the
tickets/DM-21849
branch
from
0d043a7
to
d1a6dcb
Compare
Before the root from the calibration would be used.
queryDataset returns a resolved ref so we can use it directly.
TallJimbo
force-pushed
the
tickets/DM-21849
branch
from
d1a6dcb
to
4389444
Compare
It's cleaner to call the API directly rather than forking a process since it allows pytest to look deeper into the call stack when errors occur.
TallJimbo
force-pushed
the
tickets/DM-21849
branch
from
09f5ba2
to
d3b8ace
Compare
TallJimbo
force-pushed
the
tickets/DM-21849
branch
from
9f781d9
to
3cb314f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.