Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21849: Adapt gen2to3 to use chained collections. #204

Merged
merged 13 commits into from
Mar 25, 2020
Merged

DM-21849: Adapt gen2to3 to use chained collections. #204

merged 13 commits into from
Mar 25, 2020

Commits on Mar 23, 2020

  1. Adapt gen2to3 to use chained collections.

    @TallJimbo
    TallJimbo committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    3b98ae1 View commit details
    Browse the repository at this point in the history

  2. Do not let the previous root variable leak through 

    Before the root from the calibration would be used.
    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    5b3db05 View commit details
    Browse the repository at this point in the history

  3. Use calib/[instrument] collection and empty rerun

    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    9d3fbdc View commit details
    Browse the repository at this point in the history

  4. Use getDirect to retrieve the dataset 

    queryDataset returns a resolved ref so we can use it directly.
    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    82d2ae1 View commit details
    Browse the repository at this point in the history

  5. Compare collections as sets

    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    90c1523 View commit details
    Browse the repository at this point in the history

  6. Be careful to not confuse local root variable with root parameter

    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    c961b67 View commit details
    Browse the repository at this point in the history

  7. Add some __str__ methods to aid debugging

    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    f5d7328 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Use subTest when doing some 2to3 tests

    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    1bb0824 View commit details
    Browse the repository at this point in the history

  2. Enhance the test failure message when comparing collections

    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    f5b0b2f View commit details
    Browse the repository at this point in the history

  3. Change conversion test to use the API directly 

    It's cleaner to call the API directly rather than forking
a process since it allows pytest to look deeper into the
call stack when errors occur.
    @timj @TallJimbo
    timj authored and TallJimbo committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    7cdb4de View commit details
    Browse the repository at this point in the history

  4. Make Gen3 collection names match RFC-663 conventions again.

    @TallJimbo
    TallJimbo committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    4572237 View commit details
    Browse the repository at this point in the history

  5. Minor improvements to gen2to3 logging.

    @TallJimbo
    TallJimbo committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    d3b8ace View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Fix bug in post-conversion chained collection definition.

    @TallJimbo
    TallJimbo committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3cb314f View commit details
    Browse the repository at this point in the history