DM-25152: Pre-import all known instruments before running ingest

python/lsst/obs/base/ingest.py

@@ -195,6 +195,10 @@ def __init__(self, config: Optional[RawIngestConfig] = None, *, butler: Butler,
         self.universe = self.butler.registry.dimensions
         self.datasetType = self.getDatasetType()
 
+        # Import all the instrument classes so that we ensure that we
+        # have all the relevant metadata translators loaded.
+        Instrument.importAll(self.butler.registry)
+
     def extractMetadata(self, filename: str) -> RawFileData:
         """Extract and process metadata from a single raw file.
 

python/lsst/obs/base/instrument.py

@@ -34,6 +34,7 @@
 
 if TYPE_CHECKING:
     from .gen2to3 import TranslatorFactory
+    from lsst.daf.butler import Registry
 
 # To be a standard text curated calibration means that we use a
 # standard definition for the corresponding DatasetType.
@@ -130,8 +131,8 @@ def obsDataPackageDir(self):
             self._obsDataPackageDir = getPackageDir(self.obsDataPackage)
         return self._obsDataPackageDir
 
-    @classmethod
-    def fromName(cls, name, registry):
+    @staticmethod
+    def fromName(name: str, registry: Registry) -> Instrument:
         """Given an instrument name and a butler, retrieve a corresponding
         instantiated instrument object.
 
@@ -168,6 +169,31 @@ def fromName(cls, name, registry):
         instrument = doImport(cls)
         return instrument()
 
+    @staticmethod
+    def importAll(registry: Registry) -> None:
+        """Import all the instruments known to this registry.
+
+        This will ensure that all metadata translators have been registered.
+
+        Parameters
+        ----------
+        registry : `lsst.daf.butler.Registry`
+            Butler registry to query to find the information.
+
+        Notes
+        -----
+        It is allowed for a particular instrument class to fail on import.
+        This might simply indicate that a particular obs package has
+        not been setup.
+        """
+        dimensions = list(registry.queryDimensions("instrument"))
+        for dim in dimensions:
+            cls = dim.records["instrument"].class_name
+            try:
+                doImport(cls)
+            except Exception:
+                pass
+
     def _registerFilters(self, registry):
         """Register the physical and abstract filter Dimension relationships.
         This should be called in the ``register`` implementation.