DM-27168: Phase out use of FilterProperty #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Nov 10, 2020
tests/test_butler.py
Outdated
| @@ -82,13 +82,13 @@ def assertExposure(self, exp, ccd, checkFilter=True): | |||
| print("width: ", exp.getWidth()) | |||
| print("height: ", exp.getHeight()) | |||
| print("detector name: ", exp.getDetector().getName()) | |||
| print("filter name: ", exp.getFilter().getFilterProperty().getName()) | |||
| print("filter name: ", exp.getFilter().getName()) | |||
There was a problem hiding this comment.
As in lsst/pipe_tasks#428, I'm pretty sure this is an idiom for getCanonicalName() that predates its introduction.
czwa
force-pushed
the
tickets/DM-27168
branch
from
0b92278
to
f07870f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End usage of FilterProperty, as per RFC-730.