DM-27168: Phase out use of FilterProperty #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
reviewed
Nov 10, 2020
| @@ -144,7 +144,7 @@ def getShortFilterName(name): | |||
| # I'm not sure if this is the way this is supposed to be implemented, but it seems to work, | |||
| # and its the only way I could get it to work. | |||
| try: | |||
| return afwImage.Filter(name).getFilterProperty().getName() | |||
| return afwImage.Filter(name).getName() | |||
There was a problem hiding this comment.
I believe this should be getCanonicalName(); compare the definition of getFilterProperty with the definition of getCanonicalName.
There was a problem hiding this comment.
In fact, looking at the function definition, I'm pretty sure this could be entirely removed. Maybe remove the existing comment and mark removing the function as TODO for DM-27170?
This was referenced Nov 10, 2020
|
The commit comment was fine before I rebased. I've removed it as you mention it's inaccurate now. |
czwa
force-pushed
the
tickets/DM-27168
branch
from
1ce283a
to
b847eb5
Compare
kfindeisen
approved these changes
Nov 12, 2020
czwa
force-pushed
the
tickets/DM-27168
branch
from
b847eb5
to
cdd9f35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End usage of FilterProperty, as per RFC-730.
Usage in dcrAssembleCoadd.py left as it is dealt with by DM-26615.