DM-15862: Reduce ISR code duplication between ip_isr, obs_subaru, and obs_decam #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
suggested changes
Dec 6, 2018
czwa
force-pushed
the
tickets/DM-15862
branch
4 times, most recently
from
b435ada
to
88f710c
Compare
The ISR code was split between ip_isr and the obs_ packages, with the ip_isr and obs_subaru containing parallel ISR reduction pathways. This ticket merges those pathways into a single set of ISR functions in the ip_isr package, removing the duplication of code. The merged codebase also makes additional useful functions from the obs_subaru ISR available to other cameras, and the new ISR code now profiles debug points, thumbnail images, and post-correction statistics to check processing quality. The DECam specific ISR task class, as well as the CP ISR class, have been removed in favor of the one in ip_isr. There are some changes in the ISR ordering: the variance is now constructed before the linearization instead of before. The crosstalk is performed before assembly, bias subtraction, variance construction, and linearization to better match previous processing results. To support this change, the DECam crosstalk code has been updated to ensure the corrections are aligned with the crosstalk ghosts. The isr.py configuration has been updated to explicitly list all options used for DECam. The DecamMapper has had entries for ISR thumbnails and the ISR metadata added to allow these products to be persisted.
czwa
force-pushed
the
tickets/DM-15862
branch
from
88f710c
to
0286324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DECam specific ISR task class, as well as the CP ISR class, have
been removed in favor of the one in ip_isr. There are some changes in
the ISR ordering: the variance is now constructed before the
linearization instead of before; the crosstalk is performed after
assembly, bias subtraction, variance construction, and linearization.
To support this change, the DECam crosstalk code has been altered to
ensure the corrections are aligned with the crosstalk ghosts.
The isr.py configuration has been updated to explicitly list all
options used for DECam. The DecamMapper has had entries for ISR
thumbnails and the ISR metadata added to allow these products to be
persisted.