Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-15862: Reduce ISR code duplication between ip_isr, obs_subaru, and obs_decam #100

Merged
merged 1 commit into from
Jan 4, 2019

Commits on Dec 20, 2018

  1. Reduce ISR code duplication.

    The ISR code was split between ip_isr and the obs_ packages, with the
    ip_isr and obs_subaru containing parallel ISR reduction pathways.
    This ticket merges those pathways into a single set of ISR functions
    in the ip_isr package, removing the duplication of code.  The merged
    codebase also makes additional useful functions from the obs_subaru
    ISR available to other cameras, and the new ISR code now profiles
    debug points, thumbnail images, and post-correction statistics to
    check processing quality.
    
    The DECam specific ISR task class, as well as the CP ISR class, have
    been removed in favor of the one in ip_isr.  There are some changes in
    the ISR ordering: the variance is now constructed before the
    linearization instead of before.  The crosstalk is performed before
    assembly, bias subtraction, variance construction, and linearization
    to better match previous processing results.  To support this change,
    the DECam crosstalk code has been updated to ensure the corrections
    are aligned with the crosstalk ghosts.
    
    The isr.py configuration has been updated to explicitly list all
    options used for DECam.  The DecamMapper has had entries for ISR
    thumbnails and the ISR metadata added to allow these products to be
    persisted.
    czwa committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    0286324 View commit details
    Browse the repository at this point in the history