DM-27173: Add doc field to obs.base.FilterDefinition #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
changed the title
timj
approved these changes
Jan 29, 2021
| @@ -45,6 +45,8 @@ | |||
| alias={'Y'}), | |||
| FilterDefinition(physical_filter="VR DECam c0007 6300.0 2600.0", | |||
| band="VR", | |||
| doc='A very broad-band filter, intended for "discovery", not "accurate photometry".' | |||
There was a problem hiding this comment.
Now I'm wondering what VR means. "Very R..."? And is band of "VR" a reasonable thing -- is VR a generic concept?
There was a problem hiding this comment.
My guess is that it covers both V and R: it's ~500-750nm. Sadly, the webpage I linked doesn't specify where the name comes from. I don't think it's a generic concept, but we'd want to ask a DECam person what they'd call the "band" for this one, if we don't want to go with that. Certainly, "vr" is unlikely to be a confusing band name elsewhere.
parejkoj
force-pushed
the
tickets/DM-27173
branch
from
9494f8b
to
900c0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.