Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27173: Add doc field to obs.base.FilterDefinition #178

Merged
merged 1 commit into from
Feb 1, 2021
Merged

DM-27173: Add doc field to obs.base.FilterDefinition #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/lsst/obs/decam/decamFilters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@
alias={'Y'}),
FilterDefinition(physical_filter="VR DECam c0007 6300.0 2600.0",
band="VR",
doc='A very broad-band filter, intended for "discovery", not "accurate photometry".'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm wondering what VR means. "Very R..."? And is band of "VR" a reasonable thing -- is VR a generic concept?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that it covers both V and R: it's ~500-750nm. Sadly, the webpage I linked doesn't specify where the name comes from. I don't think it's a generic concept, but we'd want to ask a DECam person what they'd call the "band" for this one, if we don't want to go with that. Certainly, "vr" is unlikely to be a confusing band name elsewhere.

'For details, wee: http://www.ctio.noao.edu/noao/content/decam-vr-filter',
lambdaEff=630, lambdaMin=490, lambdaMax=765),
FilterDefinition(physical_filter="N964 DECam c0008 9645.0 94.0",
band="N964",
Expand Down