DM-16297: Add Gen3 butler support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Jul 26, 2019
timj
force-pushed
the
tickets/DM-16297
branch
2 times, most recently
from
85001cb
to
03cc500
Compare
timj
force-pushed
the
tickets/DM-16297
branch
4 times, most recently
from
23eacbb
to
ce84327
Compare
timj
force-pushed
the
tickets/DM-16297
branch
from
ce84327
to
3b813f4
Compare
parejkoj
reviewed
Sep 12, 2019
timj
changed the title
timj
force-pushed
the
tickets/DM-16297
branch
2 times, most recently
from
985569d
to
d098d43
Compare
|
This PR requires lsst/obs_base#170 and lsst/daf_butler#173 |
czwa
approved these changes
Sep 18, 2019
| @@ -138,6 +138,10 @@ class LsstBaseTranslator(FitsTranslator): | |||
| detectorSerials = None | |||
| """Mapping of detector serial number to raft, number, and name.""" | |||
|
|
|||
| DETECTOR_MAX = 999 | |||
There was a problem hiding this comment.
This is actually a maximum detector index to use, correct? Having this be 0 for latiss confused me due to this.
There was a problem hiding this comment.
Yes. It's the maximum detector ID we can use before we change the size of the calculated detector_exposure_id
This will allow the Gen2 Mapper and the Gen3 Instrument classes to use the same definitions without depending on each other.
Tests still fail because register method does not do anything.
* writeCuratedCalibrations * applyConfigOverrides
The latter does not work properly if rmtree fails (eg on NFS) because it is not configured to ignore errors. Instead use mkdtemp in the setUp and remove it in the tearDown as is done in daf_butler.
For LATISS and TS3 at the moment since they take a while.
lsstCamMapper was not really doing anything clever to create the camera so copy the one line into gen3 instrument rather than importing the mapper code.
Without this if LsstCam is created first the subclasses won't read their cameras.
(although may be better to use pytest --profile).
This allows gen3 instrument to obtain it.
Otherwise you can get a race where pytest starts before all the camera YAML files have been created.
Although it can no longer run without a detector being supplied. We could make detector optional if we took that to mean we can skip the fix amp geometry step.
It seems that the latter has been deprecated for a while.
timj
force-pushed
the
tickets/DM-16297
branch
from
a16b6d8
to
7922e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.