DM-16297: Add Gen3 butler support #105
Commits on Sep 19, 2019
-
Refactor filter definitions into a separate file.
This will allow the Gen2 Mapper and the Gen3 Instrument classes to use the same definitions without depending on each other.
-
-
-
-
Use new scheme for getting camera
Tests still fail because register method does not do anything.
-
-
-
-
-
-
-
-
-
Add newly required instrument methods
* writeCuratedCalibrations * applyConfigOverrides
-
Use mkdtemp rather than TemporaryDirectory
The latter does not work properly if rmtree fails (eg on NFS) because it is not configured to ignore errors. Instead use mkdtemp in the setUp and remove it in the tearDown as is done in daf_butler.
-
-
-
-
For LATISS and TS3 at the moment since they take a while.
-
Create camera directly rather than going through gen2 mapper
lsstCamMapper was not really doing anything clever to create the camera so copy the one line into gen3 instrument rather than importing the mapper code.
-
-
-
Cache the camera in the class properly
Without this if LsstCam is created first the subclasses won't read their cameras.
-
If profiling, profile all the tests as one
(although may be better to use pytest --profile).
-
Move the max detector value into a translator class property
This allows gen3 instrument to obtain it.
-
Ensure that the tests depend on the policy files
Otherwise you can get a race where pytest starts before all the camera YAML files have been created.
-
-
Resurrect the utility file reader
Although it can no longer run without a detector being supplied. We could make detector optional if we took that to mean we can skip the fix amp geometry step.
-
Use fits.readMetadata not afwImage.readMetadata
It seems that the latter has been deprecated for a while.
