DM-20069: Add config and dataset for PTC task and metadata #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-20069
branch
from
c378a0d
to
1828c9b
Compare
mfisherlevine
commented
Aug 28, 2019
| config.isr.doFlat = False | ||
| config.isr.doFringe = False | ||
| config.isr.doCrosstalk = False | ||
| config.isr.doAddDistortionModel = False |
There was a problem hiding this comment.
Everything from this point downwards should live in the task's setDefaults() option I think, and especially the saturation stuff.
There was a problem hiding this comment.
Actually, I think all of the isr stuff should actually.
There was a problem hiding this comment.
That sounds reasonable to me as well.
plazas
force-pushed
the
tickets/DM-20069
branch
from
1828c9b
to
07521e1
Compare
czwa
approved these changes
Sep 6, 2019
| config.isr.doFlat = False | ||
| config.isr.doFringe = False | ||
| config.isr.doCrosstalk = False | ||
| config.isr.doAddDistortionModel = False |
There was a problem hiding this comment.
That sounds reasonable to me as well.
config/findDefects.py
Outdated
| @@ -0,0 +1,23 @@ | |||
| import os.path | |||
There was a problem hiding this comment.
Is this an orphan from another ticket? This (and the template below) do not seem associated with the PTC work.
policy/lsstCamMapper.yaml
Outdated
| @@ -463,3 +467,11 @@ datasets: | |||
| storage: FitsStorage | |||
| tables: raw | |||
| template: binned_sensor/%(dstype)s-v%(visit)08d/%(raftName)s/%(detectorName)s_%(half)s.fits | |||
| newDefects: | |||
timj
changed the title
plazas
force-pushed
the
tickets/DM-20069
branch
2 times, most recently
from
3031271
to
216fa2c
Compare
Add failing test for ComCam header Add comCam translator Ensure that detector mappings are forced to None by subclasses Without this it is possible for a subclass to pick up the detector mappings from a parent translator. Add gen2 comCam support and test file Replace afwGeom with geom Revert "Update gitignore" This reverts commit f487f44. The test data directory includes butler and fits files so we can not ignore all of them. Explicitly ignore defect fits files Add comCam test data Fix docstrings to refer to comCam rather than TS8 Remove eimage from comCam mapper Add config and dataset for defect finding task Revert "Merge branch 'tickets/DM-19709'" This reverts commit 929d6f2, reversing changes made to ce492fc. Revert "Revert "Merge branch 'tickets/DM-19709'"" This reverts commit 7f7d1e2. Add config and dataset for PTC task and metadata Added another template in lsstCammapper.yaml for PTC output data Renamed gain and noise output data product
plazas
force-pushed
the
tickets/DM-20069
branch
from
216fa2c
to
b1b76ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.