Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20069: Add config and dataset for PTC task and metadata #119

Merged
merged 1 commit into from
Oct 1, 2019
Merged

DM-20069: Add config and dataset for PTC task and metadata #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions config/measurePhotonTransferCurve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import os.path
from lsst.utils import getPackageDir

config.load(os.path.join(getPackageDir("obs_lsst"), "config", "lsstCamCommon.py"))
config.isr.load(os.path.join(getPackageDir("obs_lsst"), "config", "isr.py"))

config.ccdKey = 'detector'

config.isr.doFlat = False
config.isr.doFringe = False
config.isr.doCrosstalk = False
config.isr.doAddDistortionModel = False
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything from this point downwards should live in the task's setDefaults() option I think, and especially the saturation stuff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think all of the isr stuff should actually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds reasonable to me as well.

config.isr.doUseOpticsTransmission = False
config.isr.doUseFilterTransmission = False
config.isr.doUseSensorTransmission = False
config.isr.doUseAtmosphereTransmission = False
config.isr.doAttachTransmissionCurve = False

config.isr.doSaturation = False # critical for the turnover of the PTC to get the variance right
config.isr.doSaturationInterpolation = False
6 changes: 6 additions & 0 deletions policy/lsstCamMapper.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,12 @@ datasets:
template: calibrations/bfGain-%(detector)03d.pkl
plotBrighterFatterPtc:
template: plots/bfPtc-ccd-%(detector)03d-amp-%(amp)s.png
measurePhotonTransferCurve_metadata:
template: measurePhotonTransferCurves_metadata/%(detector)03d.yaml
measurePhotonTransferCurveGainAndNoise:
template: calibrations/ptc/ptcDataGainAndNoise-det%(detector)03d.pkl
measurePhotonTransferCurveDatasetAll:
template: calibrations/ptc/ptcDataAll-det%(detector)03d.pkl
plotCoadd:
persistable: None
python: builtins.str
Expand Down