DM-21169: Add corner rafts #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at TS8 raft nameas are preserved; update test_lsstCam.py with corner raft sensors
timj
approved these changes
Nov 13, 2019
|
|
||
| Parameters | ||
| ---------- | ||
| ccdLayout : `list` |
There was a problem hiding this comment.
This parameter has the wrong name.
|
|
||
| Returns | ||
| ------- | ||
| 2-item sequence of floats containing the rotated offsets. |
There was a problem hiding this comment.
Return should explicitly show each item separately.
| else: | ||
| doffset = (0.0, 0.0,) | ||
| yaw = None | ||
|
|
||
| print(indent(), "%s_%s : " % (raftName, ccdName), file=fd) | ||
| print(indent(), "%s_%s : " % (raftName.split('_')[0], ccdName), file=fd) |
There was a problem hiding this comment.
Is this change still needed? I see that in the commit history the name bounces from R00_W to R00W so I'm not sure if the splitting here is any longer relevant.
The gen3 test splits on _, so there can only be one of those in the full sensor name. This renames R*_W to R*W.
SimonKrughoff
force-pushed
the
tickets/DM-21169
branch
from
92f5c14
to
060c097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.