DM-22550: Fix some header translations for LATISS data #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is much shorter and removes the noqa that was masking a real issue.
An explicit function definition is clearer than lambda in this situation and does not require the noqa
Do not assign to a variable we are not going to use.
timj
force-pushed
the
tickets/DM-22550
branch
from
0a20ad4
to
39a5b0e
Compare
* GROUPID * 1970s date * Serial number
The _N is not relevant.
Normally it maps to science but science requires RA/Dec.
timj
force-pushed
the
tickets/DM-22550
branch
from
39a5b0e
to
7b68e83
Compare
Patrick Ingraham feels that this header will never give a useful value for LATISS.
Now force dark time to be the exposure time any time that the dark time is lower than the exposure time.
Otherwise we aren't really sure which observation is causing the problem.
patrickingraham
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tribeiro, @patrickingraham Can you please take a look at this. It looks like a large review but in reality it's fairly small. Please focus on the changes in latiss.py and filters.py.
There are correction files that fix the disperser->diffuser filter problem.
The important things are:
Finally, should I try to set DARKTIME to EXPTIME if it dark time is 0.0s but exp time is > 0?
Requires lsst/obs_base#190