Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-22550: Fix some header translations for LATISS data #152

Merged
merged 16 commits into from
Dec 17, 2019
Merged

DM-22550: Fix some header translations for LATISS data #152

merged 16 commits into from
Dec 17, 2019

Commits on Dec 11, 2019

  1. Ensure that FITS file is closed

    @timj
    timj committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    fd0734a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Use different filter list for LATISS and lsstCam

    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    2c1cba8 View commit details
    Browse the repository at this point in the history

  2. Add diffuser filter to LATISS

    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    e5b38af View commit details
    Browse the repository at this point in the history

  3. Use dict.get rather than if else 

    This is much shorter and removes the noqa that was masking
a real issue.
    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    5b15623 View commit details
    Browse the repository at this point in the history

  4. Define a null log command without using lambda 

    An explicit function definition is clearer than lambda in this
situation and does not require the noqa
    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    0ab72c5 View commit details
    Browse the repository at this point in the history

  5. Modify to remove need for noqa 

    Do not assign to a variable we are not going to use.
    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    162be39 View commit details
    Browse the repository at this point in the history

  6. Add some LATISS header fixups 

    * GROUPID
* 1970s date
* Serial number
    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    8a74f6a View commit details
    Browse the repository at this point in the history

  7. Map filter disperser to diffuser in some 2019-11 data

    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    26f02cc View commit details
    Browse the repository at this point in the history

  8. Map empty_N filter to EMPTY generic 

    The _N is not relevant.
    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    b7ff96b View commit details
    Browse the repository at this point in the history

  9. Allow lsstCam to define science as object or skyexp

    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    1b339a0 View commit details
    Browse the repository at this point in the history

  10. Map object to labobject in lab 

    Normally it maps to science but science requires RA/Dec.
    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    67e19ff View commit details
    Browse the repository at this point in the history

  11. Add new LATISS translator tests

    @timj
    timj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    7b68e83 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Log debug messages for each header fixup

    @timj
    timj committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    1651c4f View commit details
    Browse the repository at this point in the history

  2. Force SHUTTIME LATISS header to None 

    Patrick Ingraham feels that this header will never give a
useful value for LATISS.
    @timj
    timj committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    62bb639 View commit details
    Browse the repository at this point in the history

  3. Change dark time translation for LATISS 

    Now force dark time to be the exposure time any time
that the dark time is lower than the exposure time.
    @timj
    timj committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    aae6779 View commit details
    Browse the repository at this point in the history

  4. Add obsid to translation warnings 

    Otherwise we aren't really sure which observation is
causing the problem.
    @timj
    timj committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    d044642 View commit details
    Browse the repository at this point in the history