DM-32624: Override source selection criteria in SFM calibration stages for LSSTCam-imSim #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With minor exceptions (see below), these values match those that have been selected and in use for the major DESC/DC2 processing campaigns (e.g. DP0.1), but have thus far not been incorporated into the main branch (prior to this commit, they only lived on the dc2/run2.2 branch in obs_lsst). The situation is remedied here such that all LSSTCam-imSim data processing will inherit these overrides by default. The one real exception is that the following override has not been included: config.charImage.measurePsf.starSelector["objectSize"].signalToNoiseMin = 20 Originally, this was simply because 20 was the default (and it is preferable not to include supposed overrides in config files when the value is being set to the default). However, on further inspection (see details on DM-17043 and DM-32624) the catalogs in play for measurePsf are created with detection thresholds high enough such that typically almost no sources with S/N<~50 actually exist. This low value is not only misleading as to the range actually accessible, but also allows for the occasional lower-than-expected S/N sources to pass the thresholding tests for consideration in the PSF modeling. The default has thus been changed to 50 and this is still appropriate for LSSTCam-imSim/DC2 processing. Three other overrides that were setting to defaults were also omitted: config.charImage.measureApCorr.sourceSelector['science'].signalToNoise.maximum = None config.charImage.measureApCorr.sourceSelector['science'].signalToNoise.fluxField = 'base_PsfFlux_instFlux' config.charImage.measureApCorr.sourceSelector['science'].signalToNoise.errField = 'base_PsfFlux_instFluxErr'
yalsayyad
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.