DM-39347: Update TS8 translator #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
May 23, 2023
timj
commented
- Understand that for older data DATE-OBS is the end date.
- Use the standard exposure_id calculation for new data.
- Use TIMESYS properly when present.
jchiang87
approved these changes
May 23, 2023
These prevent the file from being corrected and mean the tests don't correctly adhere to reality.
* Add explicit DATE-END * Recalculate DATE-OBS by subtracting EXPTIME * Add DATE-BEG header * Remove specialist to_datetime_begin * Retain the TS8 test that says it has already fixed the header. This allows the original logic to be tested.
It should be an int in the headers but current data stores it as a string.
This will use the "C" controller variant for the calculation. For older data the timestamp is still used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.