DM-39415: Fix TS8 exposure ID calculation #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy scalar has difficulties converting to YAML and we need this to be a native float.
timj
commented
May 25, 2023
We have already ingested TS8 data into a butler using the old timestamp exposure_id calculation. It is very disruptive to change this because it will require the entire repository be remade from scratch. Furthermore, the fix to DATE-OBS broke all the historical calculations where the exposure_id was being derived from the end of the integration by mistake. This commit retains LSSTCam exposure_id for > 2023-05-24 and uses the original DATE-OBS value to calculate the exposure ID for older data.
jchiang87
approved these changes
May 25, 2023
|
You mean the visit_max stuff? The |
|
I think I can fix the max_exposure_id problem pretty quickly. |
This restores the TS8 exposure id maximum to a value before we switched over to using LSSTCam exposure_id. We need this to take into account the earlier data that use a timestamp and so a larger exposure ID. We do not change the value since we do not want to modify existing repositories.
|
Okay. I think I've fixed the max exposure ID. |
jchiang87
approved these changes
May 25, 2023
ktlim
reviewed
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already ingested TS8 data into a butler using the old timestamp exposure_id calculation. It is very disruptive to change this because it will require the entire repository be remade from scratch. Furthermore, the fix to DATE-OBS broke all the historical calculations where the exposure_id was being derived from the end of the integration by mistake.
This PR retains LSSTCam exposure_id for > 2023-05-24 and uses the original DATE-OBS value to calculate the exposure ID for older data.
Corrects the changes introduced in #453