Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39415: Fix TS8 exposure ID calculation #455

Merged
merged 4 commits into from
May 25, 2023
Merged

DM-39415: Fix TS8 exposure ID calculation #455

merged 4 commits into from
May 25, 2023

Commits on May 25, 2023

  1. Convert MJD-OBS to float instead of numpy scalar 

    Numpy scalar has difficulties converting to YAML and we need
this to be a native float.
    @timj
    timj committed May 25, 2023
    Configuration menu
    Copy the full SHA
    5f2fb88 View commit details
    Browse the repository at this point in the history

  2. Fix TS8 exposure id calculation for historical data 

    We have already ingested TS8 data into a butler using the old
timestamp exposure_id calculation. It is very disruptive to change
this because it will require the entire repository be remade from
scratch. Furthermore, the fix to DATE-OBS broke all the historical
calculations where the exposure_id was being derived from the end
of the integration by mistake.

This commit retains LSSTCam exposure_id for > 2023-05-24 and
uses the original DATE-OBS value to calculate the exposure ID for
older data.
    @timj
    timj committed May 25, 2023
    Configuration menu
    Copy the full SHA
    baecc94 View commit details
    Browse the repository at this point in the history

  3. Restore the original max exposure ID for TS8 

    This restores the TS8 exposure id maximum to a value before
we switched over to using LSSTCam exposure_id. We need this
to take into account the earlier data that use a timestamp
and so a larger exposure ID. We do not change the value since
we do not want to modify existing repositories.
    @timj
    timj committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7badde9 View commit details
    Browse the repository at this point in the history

  4. Anchor the TS8 exposure ID transition to observation TS_C_20230524_00… 

    …0906
    @timj
    timj committed May 25, 2023
    Configuration menu
    Copy the full SHA
    0893982 View commit details
    Browse the repository at this point in the history