DM-18051: Get defect machinery working for the AuxTel #91
Conversation
|
Am I right in thinking that a bunch of this code is copied directly from obs_subaru? At first glance that doesn't seem like a sustainable approach to development so why are we copying code around rather than putting it in obs_base or somewhere? |
|
Please remove the bad merge commit on this branch. |
Yes, that's correct, both that it was copied, and that it's not sustainable. However, it's a pattern that shouldn't be followed in general, so was decided that it wouldn't be moved to |
mfisherlevine
force-pushed
the
tickets/DM-18051
branch
3 times, most recently
from
f3d1895
to
7dfeba3
Compare
mfisherlevine
changed the title
timj
changed the title
This builds defects for auxTel
Ignore the output .fits defect files Ignore the defectRegistry
Add a SConscript file which calls genDefectFits.py and genDefectRegistry.py to build fits files from the defect.dat files, and create a defect registry at scons-time. This is following the pattern (and copying the code) in obs_subaru. It is deliberately not moving this code into obs_base nor implementing this for other parts of obs_lsst as this is a pattern we want to change, but there is no point in doing this before Gen3 or fixing up calibration stuff in general.
Change the key used Change the keys stored in the registry to be careful Store both the name and number of the detector in the defect fits file
Do this in auxTel.py so that it applies everywhere Also, fix a PEP8 violation in the spacing while there
mfisherlevine
force-pushed
the
tickets/DM-18051
branch
from
5ead679
to
46b2492
Compare
No description provided.