Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18051: Get defect machinery working for the AuxTel #91

Merged
merged 12 commits into from
Apr 3, 2019
Merged

DM-18051: Get defect machinery working for the AuxTel #91

merged 12 commits into from
Apr 3, 2019

Commits on Apr 3, 2019

  1. Fix assumption that IMGTYPE is always missing in lab data

    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    3a50da5 View commit details
    Browse the repository at this point in the history

  2. Add other config files for calib construction

    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    c648f43 View commit details
    Browse the repository at this point in the history

  3. Add config option for cosmics in darks

    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    37aad36 View commit details
    Browse the repository at this point in the history

  4. Add other config files for calib construction

    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    7fea146 View commit details
    Browse the repository at this point in the history

  5. Add path for auxTel defects

    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    b86e505 View commit details
    Browse the repository at this point in the history

  6. Add defect data for amp C17

    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    c1d351e View commit details
    Browse the repository at this point in the history

  7. Add SConstruct instruction to run auxTel/SConscript 

    This builds defects for auxTel
    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    ffa1fbe View commit details
    Browse the repository at this point in the history

  8. Update gitignore 

    Ignore the output .fits defect files
Ignore the defectRegistry
    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    f487f44 View commit details
    Browse the repository at this point in the history

  9. Add code to generate defect files and registry 

    Add a SConscript file which calls genDefectFits.py
and genDefectRegistry.py to build fits files from the
defect.dat files, and create a defect registry at
scons-time.

This is following the pattern (and copying the code)
in obs_subaru.

It is deliberately not moving this code into obs_base
nor implementing this for other parts of obs_lsst
as this is a pattern we want to change, but there is no
point in doing this before Gen3 or fixing up calibration
stuff in general.
    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    cb0047f View commit details
    Browse the repository at this point in the history

  10. Change to using detector as ccd key 

    Change the key used
Change the keys stored in the registry to be careful
Store both the name and number of the detector in the
defect fits file
    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    85a0c98 View commit details
    Browse the repository at this point in the history

  11. Turn on defects now that we have them 

    Do this in auxTel.py so that it applies everywhere
Also, fix a PEP8 violation in the spacing while there
    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    14b2ba1 View commit details
    Browse the repository at this point in the history

  12. Fix cargo culting of detector name retrieval

    @mfisherlevine
    mfisherlevine committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    46b2492 View commit details
    Browse the repository at this point in the history