DM-13260: Support construction of new HSC calibs #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rearmstr
approved these changes
Jan 29, 2018
| @@ -3,6 +3,7 @@ | |||
| config.doMaskBrightObjects = True | |||
| config.removeMaskPlanes.append("CROSSTALK") | |||
| config.doNImage = True | |||
| config.badMaskPlanes += ["SUSPECT"] | |||
There was a problem hiding this comment.
Is there anything else we currently flag as SUSPECT? We will now be masking those, maybe we should have also been doing it before.
There was a problem hiding this comment.
SUPSECT is also used to mask pixels that are beyond linearity but not saturated. I don't think that there are actually such pixels in practise in HSC, but they should always be masked.
When constructing shutter-closed calibs, we don't want to do any stray light correction.
The altitude can exceed 90 deg for day observations when the telescope isn't tracking (e.g., visit=87830 ccd=45), but afw::coord::Coord insists it must be <= 90 deg.
We don't have any correction files for the focus CCDs, so assume it's zero. This isn't ideal, but we need to do something if we're to be able to make flats and fringe frames for the focus CCDs.
The stray light is dwarfed by the light from the flat-field screen, and there is no stray light correction for certain CCDs, which means we wouldn't be able to make flats for those, which can mean we can't make flats at all.
ccd=9 is all bad, and setting it to the median of the good pixels resulted in NANs. Instead, set the correction to zero, which doesn't kill downstream processing.
Using SUSPECT instead of BAD will allow downstream processing to continue the best it can, but we'll keep those pixels out of the coadd.
That indicates the stray light correction was unavailable.
makeRGB can fail with:
SystemError: <built-in method flush of _io.BufferedWriter object at
0x2b2a0081c938> returned a result with an error set
This unhelpful error comes from the bowels of matplotlib, so not much we
can do about it except keep it from being fatal.
PaulPrice
force-pushed
the
tickets/DM-13260
branch
from
974258f
to
fc36d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.