DM-13260: Support construction of new HSC calibs

config/assembleCoadd.py

@@ -3,6 +3,7 @@
 config.doMaskBrightObjects = True
 config.removeMaskPlanes.append("CROSSTALK")
 config.doNImage = True
+config.badMaskPlanes += ["SUSPECT"]
 
 from lsst.pipe.tasks.selectImages import PsfWcsSelectImagesTask
 config.select.retarget(PsfWcsSelectImagesTask)

config/hsc/bias.py

@@ -6,3 +6,4 @@
 config.isr.retarget(SubaruIsrTask)
 config.isr.load(os.path.join(getPackageDir("obs_subaru"), "config", "hsc", "isr.py"))
 config.isr.doBrighterFatter = False
+config.isr.doStrayLight = False

config/hsc/dark.py

@@ -12,3 +12,4 @@
 config.repair.cosmicray.min_DN = 50.0
 
 config.isr.doBrighterFatter = False
+config.isr.doStrayLight = False

config/hsc/flat.py

@@ -11,3 +11,4 @@
 config.combination.vignette.load(os.path.join(getPackageDir("obs_subaru"), 'config', 'hsc', 'vignette.py'))
 
 config.isr.doBrighterFatter = False
+config.isr.doStrayLight = False

config/hsc/isr.py

@@ -13,6 +13,7 @@
 config.doDark = True # Required especially around CCD 33
 config.doFringe = True
 config.fringe.filters = ['y', 'N921', 'N926', 'N973', 'N1010']
+config.fringe.stats.badMaskPlanes += ["SUSPECT"]  # stray light correction unavailable
 config.doWrite = False
 config.doCrosstalk = True
 config.doGuider = False

python/lsst/obs/hsc/makeHscRawVisitInfo.py

@@ -47,9 +47,14 @@ def setArgDict(self, md, argDict):
             self.popAngle(md, "RA2000", units=astropy.units.h),
             self.popAngle(md, "DEC2000"),
         )
+        altitude = self.popAngle(md, "ALTITUDE")
+        if altitude > 90*degrees:  # Sometimes during day observations, when not tracking
+            if self.log is not None:
+                self.log.warn("Clipping altitude (%f) at 90 degrees", altitude)
+            altitude = 90*degrees
         argDict["boresightAzAlt"] = Coord(
             self.popAngle(md, "AZIMUTH"),
-            self.popAngle(md, "ALTITUDE"),
+            altitude,
         )
         argDict["boresightAirmass"] = self.popFloat(md, "AIRMASS")
         argDict["observatory"] = self.observatory

python/lsst/obs/subaru/isr.py

@@ -498,10 +498,18 @@ def writeThumbnail(self, dataRef, dataset, exposure):
         stats = afwMath.makeStatistics(binnedImage,
                                        afwMath.MEDIAN | afwMath.STDEVCLIP | afwMath.MAX, statsCtrl)
         low = stats.getValue(afwMath.MEDIAN) - self.config.thumbnailStdev*stats.getValue(afwMath.STDEVCLIP)
-        makeRGB(binnedImage, binnedImage, binnedImage, minimum=low, dataRange=self.config.thumbnailRange,
-                Q=self.config.thumbnailQ, fileName=filename,
-                saturatedBorderWidth=self.config.thumbnailSatBorder,
-                saturatedPixelValue=stats.getValue(afwMath.MAX))
+        try:
+            makeRGB(binnedImage, binnedImage, binnedImage, minimum=low, dataRange=self.config.thumbnailRange,
+                    Q=self.config.thumbnailQ, fileName=filename,
+                    saturatedBorderWidth=self.config.thumbnailSatBorder,
+                    saturatedPixelValue=stats.getValue(afwMath.MAX))
+        except Exception as exc:
+            # makeRGB can fail with:
+            #     SystemError: <built-in method flush of _io.BufferedWriter object at 0x2b2a0081c938>
+            #     returned a result with an error set
+            # This unhelpful error comes from the bowels of matplotlib, so not much we can do about it
+            # except keep it from being fatal.
+            self.log.warn("Unable to write thumbnail for %s: %s", dataRef.dataId, exc)
 
     def measureOverscan(self, ccdExposure, amp):
         clipSigma = 3.0

python/lsst/obs/subaru/strayLight/yStrayLight.py

@@ -80,6 +80,9 @@ def run(self, sensorRef, exposure):
         if filterName != 'y':
             # No correction to be made
             return
+        if sensorRef.dataId["ccd"] in range(104, 112):
+            # No correction data: assume it's zero
+            return
 
         # The LEDs that are causing the Y straylight have not been covered yet (on 2017-11-27),
         # but they will be covered in the near future.
@@ -113,9 +116,12 @@ def run(self, sensorRef, exposure):
                 amp = exposure.getDetector()[ii]
                 box = amp.getBBox()
                 isBad[box.getBeginY():box.getEndY(), box.getBeginX():box.getEndX()] = True
-            model[isBad] = numpy.median(model[~isBad])
             mask = exposure.getMaskedImage().getMask()
-            mask.array[isBad] |= mask.getPlaneBitMask("BAD")
+            if numpy.all(isBad):
+                model[:] = 0.0
+            else:
+                model[isBad] = numpy.median(model[~isBad])
+            mask.array[isBad] |= mask.getPlaneBitMask("SUSPECT")
 
         model *= exposure.getInfo().getVisitInfo().getExposureTime()
         exposure.image.array -= model