DM-16819: fixes to raw formatters #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gen2 seems to have have always done this incorrectly given that the flipping that happens in std_raw should have been considered when interpreting the bounding boxes. In Gen3 we'll instead refuse to do it (unless we decide we need it later). This does slow down a unit test (because we need to read a full file in it).
TallJimbo
force-pushed
the
tickets/DM-16819
branch
from
4d5a006
to
af5b372
Compare
natelust
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually these should have been added as part of DM-15503, but they weren't discovered until tests were added (in ci_hsc) on this ticket.