DM-39227: drop overrides for deprected config options #456
Conversation
TallJimbo
force-pushed
the
tickets/DM-39227
branch
from
01fc514
to
7605435
Compare
| @@ -6,6 +6,3 @@ | |||
| config.measurement.plugins["base_CircularApertureFlux"].radii = [12.0] | |||
|
|
|||
| config.measurement.slots.gaussianFlux = None | |||
| config.doApplyExternalPhotoCalib = True | |||
| config.doApplyExternalSkyWcs = True | |||
| config.doApplySkyCorr = True | |||
There was a problem hiding this comment.
Are skyCorr datasets also being bundled into finalVisitSummary tables? From looking through the forcedPhotCcd script in the meas_base PR, I don't think so?
There was a problem hiding this comment.
Ah, good catch. Backgrounds are not in visit summaries, and I think removing this last line was a mistake.
| config.doApplyExternalPhotoCalib = True | ||
| config.doApplyExternalSkyWcs = True |
There was a problem hiding this comment.
By removing these doApply... configs (here and elsewhere), are we also removing the flexibility to turn these components off? I see a new useVisitSummaryPsf config option - do we also need similar useVisitSummaryPhotoCalib and useVisitSummaryWcs configs to replicate this functionality?
There was a problem hiding this comment.
No, we are intentionally dropping this functionality here, because the expectation is that controlling what goes into a visit summary dataset (which still has these knobs) is sufficient for everything downstream of that visit summary and upstream of any other visit summary.
There was a problem hiding this comment.
Got it, thanks for the explanation, good to know!
|
Other than a |
The correct external-calibs behavior no longer requires different per-instrument configs.
The correct external-calibs behavior no longer requires different per-instrument configs.
These overrides are for subtask usage of AssembleCoaddTask, which gets these config options from CoaddBaseTask but doesn't use them (they should have only been options for MakeWarpTask, but they're being deprecated anyway).
TallJimbo
force-pushed
the
tickets/DM-39227
branch
from
7605435
to
91f24a9
Compare
No description provided.