Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39227: drop overrides for deprected config options #456

Merged
merged 4 commits into from
Jul 13, 2023
Merged

DM-39227: drop overrides for deprected config options #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0448e2
Drop usage of deprecated ForcedPhotCcd config options.
TallJimbo Jun 30, 2023
9bfa9e9
Drop usage of deprecated MakeWarp config options.
TallJimbo Jun 30, 2023
540531f
Drop Gen2-era makeCoaddTempExp config overrides.
TallJimbo Jun 30, 2023
91f24a9
Remove unnecessary overrides for compareWarpAssembleCoadd.
TallJimbo Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/coaddBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
# Configs shared between makeWarp and assemble
config.matchingKernelSize = 29
config.doApplyExternalPhotoCalib = True
config.doApplyExternalSkyWcs = True
Comment on lines -3 to -4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing these doApply... configs (here and elsewhere), are we also removing the flexibility to turn these components off? I see a new useVisitSummaryPsf config option - do we also need similar useVisitSummaryPhotoCalib and useVisitSummaryWcs configs to replicate this functionality?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we are intentionally dropping this functionality here, because the expectation is that controlling what goes into a visit summary dataset (which still has these knobs) is sufficient for everything downstream of that visit summary and upstream of any other visit summary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the explanation, good to know!

2 changes: 0 additions & 2 deletions config/compareWarpAssembleCoadd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,4 @@

# 200 rows (since patch width is typically < 10k pixels
config.assembleStaticSkyModel.subregionSize = (10000, 200)
config.assembleStaticSkyModel.doApplyExternalPhotoCalib = True
config.assembleStaticSkyModel.doApplyExternalSkyWcs = True
config.doFilterMorphological = True
2 changes: 0 additions & 2 deletions config/forcedPhotCcd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,4 @@
config.measurement.plugins["base_CircularApertureFlux"].radii = [12.0]

config.measurement.slots.gaussianFlux = None
config.doApplyExternalPhotoCalib = True
config.doApplyExternalSkyWcs = True
config.doApplySkyCorr = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are skyCorr datasets also being bundled into finalVisitSummary tables? From looking through the forcedPhotCcd script in the meas_base PR, I don't think so?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Backgrounds are not in visit summaries, and I think removing this last line was a mistake.

3 changes: 0 additions & 3 deletions config/makeCoaddTempExp.py
View file
Open in desktop

This file was deleted.