Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21064: Clean up license and dependencies #41

Merged
merged 8 commits into from Aug 28, 2019
Merged

DM-21064: Clean up license and dependencies #41

merged 8 commits into from Aug 28, 2019

Conversation

timj
Copy link
Member

@timj timj commented Aug 23, 2019

  • Update prologues to be current DM standard.
  • Add COPYRIGHT file
  • Remove dependency on utils
  • Make daf_base and pex_policy optional

@timj
Remove unnecessary root __init__.py and remove lsstimport usage
d79f2ed
@timj
Use modern-style license prologues in source code
6c97b4f
@timj
Add explicit GPL license file
7fec37c
@timj
Add initial COPYRIGHT file
73ea3e8 
If an institution only contributed a few lines in the year it is
not counted as a copyright holder.
@timj
Be consistent with __all__ placement at top of files
149b448
@timj
Remove dependency on lsst.utils
82d6261 
* MemoryTestCase is no longer useful (and probably never was
  given Citizen is not used in pex_config)
* getPackageDir replaced by use of __file__
@timj timj requested review from jonathansick and ktlim and removed request for jonathansick August 23, 2019 21:55
ktlim
ktlim approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that we're losing open-fd protection for a package that does manipulate files, but it's a relatively small price for eliminating utils.

tests/test_configDictField.py Outdated Show resolved Hide resolved
@timj
Modernize asserts when comparing with bool, None, or "in"
1fa81f8
@timj
Make pex_policy and daf_base optional
5078b6a 
makePropertySet and makePolicy will now fail at runtime if they
are not available.
@timj timj merged commit 919ecaf into master Aug 28, 2019
@timj timj deleted the tickets/DM-21064 branch August 28, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktlim ktlim ktlim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @ktlim