DM-23616: Run converted ap_verify testdata through gen3 pipeline #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Mar 26, 2020
| datasetType = connection.makeDatasetType(universe) | ||
|
|
||
| # copied from TaskDatasetTypes.fromTaskDef | ||
| if "skypix" in connection.dimensions: |
There was a problem hiding this comment.
A short explanation as to why this specialization is necessary would be useful.
Because handling skypix requires access to a Butler registry, it needs to be done outside of `DimensionedConnection.makeDatasetType`.
While for most testing purposes a Quantum need only have data IDs for its inputs and outputs, some tasks try to parse the ID of the quantum itself.
kfindeisen
force-pushed
the
tickets/DM-23616
branch
from
82d9ea6
to
782df4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs and missing features in the PipelineTask test framework (
pipe.base.testUtils) in response to trying to apply it toCalibrateTaskon lsst/pipe_tasks#362.