DM-23616: Run converted ap_verify testdata through gen3 pipeline #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Mar 26, 2020
CalibrateTask treats reference catalogs as an input, but removes them from the input collection when they are used. This lead to the counterintuitive behavior where the catalogs would be passed to `run` (triggering an "unknown keyword" error) only if they were not needed.
The Gen 2 code checked whether the matches existed; the Gen 3 code did not.
kfindeisen
force-pushed
the
tickets/DM-23616
branch
from
2526acf
to
094ed12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some connection-handling logic in
CalibrateTask. The changes to the task itself are straightforward; most of the code changes are from creating a new unit test framework forCalibrateTaskand creating enough mock data to satisfyCalibrateTask.runQuantum.