DM-34590: --longlog requires an unnecessary argument #245
Conversation
--longlog is supposed to be a switch, and not require an argument, but it was requiring one due to the absence of nargs=0.
|
I am pondering whether we really want to be doing gen2 fixes at this point since we are going to be deleting it soon. I think I'd rather there wasn't a change log entry for it since advertising gen2 bug fixes when we are saying everywhere else that gen2 is going away imminently might be more confusing than helpful. |
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 72.14% 72.17% +0.03%
==========================================
Files 60 60
Lines 6628 6628
Branches 1250 1250
==========================================
+ Hits 4782 4784 +2
+ Misses 1621 1620 -1
+ Partials 225 224 -1
Continue to review full report at Codecov.
|
|
@andy-slac The mypy failure appears to be related to DM-33493. |
|
Which was #242 and did pass mypy at the time. I wonder if the mypy version changed. |
|
mypy was 0.942 and is now 0.950. (conda does not seem to have 0.950 yet) |
| self.add_argument("--longlog", action=LongLogAction, help="use a more verbose format for the logging") | ||
| self.add_argument( | ||
| "--longlog", | ||
| nargs=0, |
There was a problem hiding this comment.
I'm guessing this broke in DM-19634 (#178).
There was a problem hiding this comment.
We have no expectations that this will survive past the next weekly.
We don't want to give people the impression that Gen2 is under active development.
python/lsst/pipe/base/graph/_loadHelpers.py:254: error: Argument 1 to UUID has incompatible type UUID; expected Optional[str] python/lsst/pipe/base/graph/_loadHelpers.py:254: error: Subclass of UUID and str cannot exist: would have incompatible method signatures The declared type of 'nodes' didn't match how it was being used (declared as iterable of UUID, but treated as if it might be an iterable of strings or UUID). Fixed the declared types rather than changing the behaviour. Looks like this only started showing up in mypy 0.950.
PaulPrice
force-pushed
the
tickets/DM-34590
branch
from
a20f763
to
f6f13eb
Compare
--longlog is supposed to be a switch, and not require an argument,
but it was requiring one due to the absence of nargs=0.
Checklist
doc/changes