Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34590: --longlog requires an unnecessary argument #245

Merged
merged 3 commits into from
Apr 29, 2022
Merged

DM-34590: --longlog requires an unnecessary argument #245

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2324787
argumentParser: remove unnecessary argument from --longlog
PaulPrice Apr 28, 2022
877b000
remove changlog entry for Gen2 middleware
PaulPrice Apr 28, 2022
f6f13eb
graph: fix mypy failure in DefaultLoadHelper.load
PaulPrice Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/DM-34590.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug where the Gen2 argument parser required an unused parameter for `--longlog`.
7 changes: 6 additions & 1 deletion python/lsst/pipe/base/argumentParser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,12 @@ def __init__(self, name, usage="%(prog)s input [options]", **kwargs):
help="logging level; supported levels are [trace|debug|info|warn|error|fatal]",
metavar="LEVEL|COMPONENT=LEVEL",
)
self.add_argument("--longlog", action=LongLogAction, help="use a more verbose format for the logging")
self.add_argument(
"--longlog",
nargs=0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this broke in DM-19634 (#178).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no expectations that this will survive past the next weekly.

action=LongLogAction,
help="use a more verbose format for the logging",
)
self.add_argument("--debug", action="store_true", help="enable debugging output?")
self.add_argument(
"--doraise",
Expand Down