Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34954: Fix Instrument.from_string see also section #252

Merged
merged 1 commit into from May 25, 2022
Merged

DM-34954: Fix Instrument.from_string see also section #252

merged 1 commit into from May 25, 2022

Conversation

jonathansick
Copy link
Member

Numpydoc 1.2 was showing this See Also section with an extra () as an error instead of a warning.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@jonathansick
Fix Instrument.from_string see also section
b5db31c 
Numpydoc 1.2 was showing this as an error instead of a warning.
@jonathansick jonathansick requested a review from timj May 25, 2022 20:52
timj
timj approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Turns out I had not quite got around to doing the sphinx build in this package (I only just made the gen2 stuff optional)

@jonathansick jonathansick merged commit c789015 into main May 25, 2022
@jonathansick jonathansick deleted the tickets/DM-34954 branch May 25, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathansick @timj