Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35347: Switch to pyproject.toml #260

Merged
merged 1 commit into from Jul 14, 2022
Merged

DM-35347: Switch to pyproject.toml #260

merged 1 commit into from Jul 14, 2022

Conversation

mwittgen
Copy link
Contributor

@mwittgen mwittgen commented Jul 7, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #260 (5dd1069) into main (d1a5d7e) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 5dd1069 differs from pull request most recent head f593743. Consider uploading reports for the commit f593743 to get more accurate results

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   72.29%   72.20%   -0.10%     
==========================================
  Files          60       60              
  Lines        6768     6734      -34     
  Branches     1393     1387       -6     
==========================================
- Hits         4893     4862      -31     
+ Misses       1651     1649       -2     
+ Partials      224      223       -1     
Impacted Files Coverage Δ
python/lsst/pipe/base/config.py 68.42% <0.00%> (-1.08%) ⬇️
python/lsst/pipe/base/graph/graph.py 81.81% <0.00%> (-0.85%) ⬇️
...thon/lsst/pipe/base/graph/_versionDeserializers.py 63.20% <0.00%> (-0.55%) ⬇️
python/lsst/pipe/base/pipeline.py 61.52% <0.00%> (-0.10%) ⬇️
python/lsst/pipe/base/testUtils.py 92.46% <0.00%> (ø)
python/lsst/pipe/base/graph/_loadHelpers.py 84.61% <0.00%> (ø)
tests/test_quantumGraph.py 95.58% <0.00%> (+0.44%) ⬆️
python/lsst/pipe/base/tests/simpleQGraph.py 69.93% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a5d7e...f593743. Read the comment docs.

@mwittgen mwittgen force-pushed the tickets/DM-35347 branch 5 times, most recently from 50eaf4a to ea961b2 Compare July 12, 2022 21:41
@mwittgen mwittgen requested a review from timj July 13, 2022 00:12
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I think the mypy fixes are waiting on #259

pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@mwittgen mwittgen merged commit 835a13a into main Jul 14, 2022
@mwittgen mwittgen deleted the tickets/DM-35347 branch July 14, 2022 00:37
@mwittgen
Copy link
Contributor Author

Added two commits with the black and isort fixes, running jenkins right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants