DM-36080: Remove an assert against component outputs. #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 10, 2022
Codecov ReportBase: 81.84% // Head: 81.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 81.84% 81.83% -0.01%
==========================================
Files 56 56
Lines 6146 6145 -1
Branches 1126 1126
==========================================
- Hits 5030 5029 -1
Misses 885 885
Partials 231 231
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The assert inadvertently catches component *inputs* because of an unidentified bug elsewhere. This breaks all pipelines that use the default config for ip.diffim.GetTemplateTask.
kfindeisen
force-pushed
the
tickets/DM-36080
branch
from
4a6f03f
to
759a9bc
Compare
|
Merging immediately, because this bug breaks GHA builds on lsst-dm/prompt_processing#24. Edit: aaaand I forgot that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert inadvertently catches component inputs because of an unidentified bug elsewhere. This breaks all pipelines that use the default config for
ip.diffim.GetTemplateTask.