New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-40381: Improve mock support and fix bugs in init-input/output handling in QBB #368
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 84.11% 83.40% -0.71%
==========================================
Files 77 77
Lines 9082 9173 +91
Branches 1740 1579 -161
==========================================
+ Hits 7639 7651 +12
- Misses 1158 1232 +74
- Partials 285 290 +5
☔ View full report in Codecov by Sentry. |
This will give MockDataset more flexibility as to which DatasetRef attributes can be `None` and free us from using SerializedDataCoordinate, which is just less convenient than a plane dict in this context.
Not implementing adjustQuantum was an oversight in the mock reimplementation of DM-38952. The other hooks are recent additions and aren't yet used, but implementing them now saves work on DM-38498.
40499fa
to
722c510
Compare
ecf5219
to
a7b8c0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The barren wasteland that is test coverage on this PR really makes me think that at some point we need to add coverage recording for middleware to ci_middleware so we can get some idea of what our coverage really is.
ci_middleware is already recording all of the coverage it's providing when it's run, but it's a pain to use, because you have to run it locally (and be careful about cleaning up coverage outputs from previous runs) and then do |
When all of a task's quanta are skipped (generally because they already ran successfully) in QG generation, it's cleanest to drop that task from the QG entirely. This also includes redefining all of that task's initOutputs that were pipeline-level initIntermediates as overall initInputs.
a7b8c0e
to
fd98449
Compare
Depends on lsst/daf_butler#879
Checklist
doc/changes