DM-14366: Make pipe_base and pipe_tasks pep8 compliant #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
May 11, 2018
python/lsst/pipe/base/cmdLineTask.py
Outdated
| @@ -50,7 +50,7 @@ def _poolFunctionWrapper(function, arg): | |||
| return function(arg) | |||
| except Exception: | |||
| raise # No worries | |||
| except: | |||
| except: # noqa E722 | |||
There was a problem hiding this comment.
See the discussion in lsst-dm/legacy-pipe_supertask#17 where I discussed this exact problem with @andy-slac -- I think this should be BaseException or should maybe disappear completely in Python 3 land.
There was a problem hiding this comment.
Perfect. I'll remove it.
timj
approved these changes
May 11, 2018
python/lsst/pipe/base/cmdLineTask.py
Outdated
| @@ -173,7 +173,7 @@ class TaskRunner(object): | |||
| .. __: http://stackoverflow.com/questions/1408356/keyboard-interrupts-with-pythons-multiprocessing-pool | |||
| """ | |||
|
|
|||
| TIMEOUT = 3600*24*30 | |||
| TIMEOUT = 3600 * 24 * 30 | |||
There was a problem hiding this comment.
I thought we required multiplications to not have spaces.
There was a problem hiding this comment.
Thanks. I think I ran autopep8 and didn't notice the change.
which are generated when pytest is run manually
The code in question is not needed in modern Python
|
It would probably be better to include E226, but since this is already merged, I suggest a new ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.