DM-14359: Fix data ID handling in ap_* #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r-owen how long until you can merge your flake8 travis fixup that's causing these complaints? I think we need to be very careful to only turn on travis if the travis yaml and flake8 cleanups are going to be merged in less than a day, otherwise other people trip over the problem and end up redoing the work themselves. |
|
I'm reviewing #49 today. |
|
Thanks, somehow I missed that one. I'll remove my second commit then. |
kfindeisen
force-pushed
the
tickets/DM-14359
branch
from
4f1199d
to
5026eaf
Compare
kfindeisen
force-pushed
the
tickets/DM-14359
branch
from
5026eaf
to
be6bbc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out data ID expansion and verification from
DataRefContainer, moving it intodaf_persistenceso that it can be used by other code.This PR must be merged after lsst-dm/legacy-daf_persistence#93.