DM-5348 #9
Merged
DM-5348 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-5348
branch
6 times, most recently
from
db3b758
to
64bb4c1
Compare
The parser was calling castDataIds on data ID containers that had no dataset type. That is illegal. Now the code checks.
r-owen
force-pushed
the
tickets/DM-5348
branch
2 times, most recently
from
4d520af
to
741d34d
Compare
Enhance support for dynamic dataset types in the argument parser. Add DynamicDatasetType: a base class for dynamic dataset types that supports computing dataset type from any parsed information. Make DatasetArgument a subclass of DynamicDatasetType and make it add the argument itself, to simplify the code. Add ConfigDatasetType as another subclass, one that determines the dataset type from a config parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.