Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-5348 #9

Merged
merged 5 commits into from
Mar 9, 2016
Merged

DM-5348 #9

merged 5 commits into from
Mar 9, 2016

Commits on Mar 9, 2016

  1. Fix typo in doc string

    @r-owen
    r-owen committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    ad97f76 View commit details
    Browse the repository at this point in the history

  2. Fixed handling of data ID containers with no datasetType 

    The parser was calling castDataIds on data ID containers that had no
dataset type. That is illegal. Now the code checks.
    @r-owen
    r-owen committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    1bf0a8b View commit details
    Browse the repository at this point in the history

  3. Make dynamic dataset types more flexible 

    Enhance support for dynamic dataset types in the argument parser.
Add DynamicDatasetType: a base class for dynamic dataset types
that supports computing dataset type from any parsed information.
Make DatasetArgument a subclass of DynamicDatasetType and make it
add the argument itself, to simplify the code.
Add ConfigDatasetType as another subclass, one that determines the
dataset type from a config parameter.
    @r-owen
    r-owen committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    df99f18 View commit details
    Browse the repository at this point in the history

  4. Add unit test for DatasetArgument

    @r-owen
    r-owen committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    70f060e View commit details
    Browse the repository at this point in the history

  5. Add unit test for ConfigDatasetType

    @r-owen
    r-owen committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    741d34d View commit details
    Browse the repository at this point in the history