Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-20376: Correct exit status #97

Closed
wants to merge 3 commits into from
Closed

DM-20376: Correct exit status #97

wants to merge 3 commits into from

Conversation

timj
Copy link
Member

@timj timj commented Aug 7, 2019

No description provided.

@kfindeisen
Copy link
Member

Please make sure this PR also updates the Sphinx documentation on status codes (in particular, the cap of 127).

@ktlim
Copy link
Contributor

ktlim commented Aug 8, 2019

Do you think I should increase that to 255? Traditionally 128-255 has been reserved for signal-caused exits, but I can imagine we would like to have, for example, 189 (CCDs in focal plane) available.
255 is a hard limit, of course. I guess there should also be at least a log message if we exceed whatever cap there is.

@andy-slac
Copy link
Contributor

Exit codes above 127 are still interpreted as "exited due to signal". It may confuse users if parent process says "child was killed by signal 61 (core dumped)".

@timj
Copy link
Member Author

timj commented Sep 11, 2020

@ktlim are we abandoning this branch? It's gen2-specific. @andy-slac is there an equivalent case in pipetask?

@andy-slac
Copy link
Contributor

@timj, I believe pipetask should exit with non-zero code on any error. Proving that may be as hard as solving halting problem 🙂

@timj
Copy link
Member Author

timj commented Aug 2, 2021

Are we going to try to merge this or are we going to close it and the associated Jira ticket?

@timj
Copy link
Member Author

timj commented Aug 16, 2022

The CmdLineTask code no longer exists.

@timj timj closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants