Tickets/dm-3766: A new Task ingestCalibs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from lsst.pipe.tasks.ingest import RegisterTask, ParseTask, RegisterConfig | ||
|
|
||
| def _convertToDate(dateString): | ||
| """Convert a string into a date""" |
There was a problem hiding this comment.
It's converting a string into a date object. "date" is ambiguous as it could just mean that it is finding the date in the string and returning the date as a string. I know it's a "private" method, but it should document that it returns None if no date string can be located.
hsinfang
force-pushed
the
tickets/DM-3766
branch
3 times, most recently
from
5f9036b
to
7627862
Compare
Same behaviors are kept by default.
hsinfang
force-pushed
the
tickets/DM-3766
branch
4 times, most recently
from
0fa09db
to
742511f
Compare
It uses and expands IngestTask to parse through the file headers for information and add to the calibration registry of the data repository. Dataset type (e.g. bias/dark/flat/fringe) is determined by the header info OBSTYPE, and by default the calibration images are valid on the observation date only. Optional argument "validity" can be used to set a wider validity period on the command line. Overlaps in validity ranges are fixed.
hsinfang
force-pushed
the
tickets/DM-3766
branch
from
742511f
to
5c91ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ingest.py is modified slightly for more general use, and ingestCalibs.py is created for parsing through calibration data and creating a calibration registry.