DM-21452: Deal with undefined values in ingest #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PropertySet/PropertyList now handles undefined values in the FITS headers, but the ingest script treats them as None and blows up. Handle these cases explicitly.
raise(Exception) raises the class 'Exception', which can't be the intention. If the intention was to allow the exception to propagate, then removing the catch completely does that.
The filter isn't set in the files we're ingesting, so to prevent a None value we need to provide a default. We can't simply remove the filter from the required columns because ingestCalibs assumes that the schema for defects and other calibs are the same.
PaulPrice
force-pushed
the
tickets/DM-21452
branch
from
674772d
to
9ba9e41
Compare
natelust
approved these changes
Oct 3, 2019
SimonKrughoff
added a commit
that referenced
this pull request
Nov 8, 2019
SimonKrughoff
added a commit
that referenced
this pull request
Nov 8, 2019
SimonKrughoff
added a commit
that referenced
this pull request
Nov 8, 2019
SimonKrughoff
added a commit
that referenced
this pull request
Nov 20, 2019
SimonKrughoff
added a commit
that referenced
this pull request
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.