Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21155: generalize how standardized text files are ingested as calibs #320

Merged
merged 16 commits into from Nov 27, 2019
Merged

DM-21155: generalize how standardized text files are ingested as calibs #320

merged 16 commits into from Nov 27, 2019

Conversation

SimonKrughoff
Copy link
Contributor

No description provided.

@SimonKrughoff SimonKrughoff force-pushed the tickets/DM-21155 branch 2 times, most recently from a50e129 to 8a24a15 Compare November 5, 2019 19:26
timj
timj approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor comments but looks like a nice generalization. "StdText" looks odd to me now I see it written down. Would "ingestTextCalibs" work instead?

python/lsst/pipe/tasks/ingestStdTextCalibs.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/read_stdText_calibs.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/read_stdText_calibs.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/read_stdText_calibs.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/read_stdText_calibs.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/read_stdText_calibs.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/read_stdText_calibs.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/read_stdText_calibs.py Outdated Show resolved Hide resolved
tests/test_read_StdTextCalibs.py Outdated Show resolved Hide resolved
tests/test_read_StdTextCalibs.py Outdated Show resolved Hide resolved
@SimonKrughoff SimonKrughoff force-pushed the tickets/DM-21155 branch 2 times, most recently from fea5bc5 to de393f5 Compare November 8, 2019 23:13
@SimonKrughoff SimonKrughoff merged commit 943e6d7 into master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonKrughoff @timj