DM-23008: Add a script to define DCR subfilters in a Gen 3 registry. #338
Conversation
isullivan
force-pushed
the
tickets/DM-23008
branch
from
b413532
to
449cf53
Compare
| """ | ||
|
|
||
| def __init__(self, *, config=None, **kwargs): | ||
| super().__init__(config=config, **kwargs) |
There was a problem hiding this comment.
Do you need this init if you are doing nothing?
There was a problem hiding this comment.
I'm afraid I was just following what you did in MakeGen3SkyMapTask.
I assumed there was a reason we needed to strip positional arguments from __init__, but if that's not needed I'm happy to remove this.
There was a problem hiding this comment.
It may have been put in as a safeguard since Task takes config as a positional argument, and this ensures that happens correctly.
There was a problem hiding this comment.
OK. I think I will leave it in, then, but I'll add a comment.
bin.src/makeGen3DcrSubfilters.py
Outdated
| # Build a parser for command line arguments | ||
| parser = argparse.ArgumentParser(description="Define the set of subfilters for chromatic modeling.") | ||
| parser.add_argument("butler", metavar="Butler", type=str, help="Path to a gen3 butler") | ||
| parser.add_argument("collection", type=str, metavar="Collection", |
There was a problem hiding this comment.
follow DM-21246 that is going into review now-ish, and that will remove the need for the collection argument to create a butler, since what you are doing is not dependent on a butler at all.
| ) | ||
|
|
||
|
|
||
| class MakeGen3DcrSubfiltersTask(pipeBase.Task): |
There was a problem hiding this comment.
Will you be running this command multiple times for multiple filters to add subbands for them all? Then I think it might be worth it to use ListFields in the config and do them all at once here. At the very least it gives you the option to do it all at once, and still have a single entry if that is all you need.
isullivan
force-pushed
the
tickets/DM-23008
branch
2 times, most recently
from
adf1306
to
c9f076c
Compare
isullivan
force-pushed
the
tickets/DM-23008
branch
from
c9f076c
to
97020d4
Compare
No description provided.