DM-23946: Change localWcs plugins to use a localGnomonicWcs transform. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
force-pushed
the
tickets/DM-23946
branch
from
17f0d0a
to
5a7aadc
Compare
morriscb
force-pushed
the
tickets/DM-23946
branch
from
94c224a
to
b50fac0
Compare
TallJimbo
commented
Apr 15, 2020
| ------- | ||
| raDecTuple : tuple | ||
| RA and dec conversion of x and y given the local Wcs. Returned | ||
| units are in radians. |
There was a problem hiding this comment.
I think the documentation for tuple returns is to document each tuple element separately, i.e.:
Returns
------
ra : `pandas.Series`
RA coordinate from conversion of (x, y)
dec : ...
Also, if the arguments could be scalar floats or np.ndarray as well as pandas.Series, it's probably best to document that somehow. Maybe @jonathansick has thoughts on how - there's no single interface type AFAIK, but it's got to be a common pattern.
| """ | ||
| return (x * cd11 + y * cd12, x * cd21 + y * cd22) | ||
|
|
||
| def computeSkySeperation(self, ra1, dec1, ra2, dec2): |
There was a problem hiding this comment.
typo: separation (also below)
Several tests/changes were performed during the corse of this ticket including different wcs approximations. To see the full set of attempts see: https://jira.lsstcorp.org/browse/DM-23946 Debug test fuctors Test different declinations Change dec range Debug setting declination. Add random xy locations. Change LocalWcs functors and tests. Debug and change distance to 3 vectors. addapt functors and unittests. Debug unittests.
morriscb
force-pushed
the
tickets/DM-23946
branch
from
3834232
to
3b9ae51
Compare
morriscb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug test fuctors